Make nightly build again (trailing semicolons in macro in expressions) - #2827
Open
knoellle wants to merge 2 commits into
Open
Make nightly build again (trailing semicolons in macro in expressions)#2827knoellle wants to merge 2 commits into
knoellle wants to merge 2 commits into
Conversation
paudar
reviewed
Aug 5, 2026
paudar
left a comment
paudar
left a comment
Contributor
There was a problem hiding this comment.
I run the pepsi command as stated in the how to test section and got the same warnings as output as on main. Is that expected behavior?
(All of the warnings give a hint to explicitly specify a number as f32)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why? What?
The bail macro cannot be used in an expression context in latest rust nightly, causing compilation to fail. This PR changes all our
bail!invocations to be in a statement context, making everything compile again.I also added a shim to version-launder
cfg_aliasescrate since it suffers from the same issue and outdated versions of it lurk in our dependency tree.Rust tracking issue #79813
ToDo / Known Issues
Ideas for Next Iterations (Not This PR)
How to Test